From cd2f100f0f61b3f333d52d1737dd73f02daee592 Mon Sep 17 00:00:00 2001 From: Konrad Rzeszutek Wilk Date: Wed, 18 Mar 2015 20:24:19 -0400 Subject: [PATCH] libxc: Fix do_memory_op to return negative value on errors instead of the -Exx values (which should go in errno). This patch has HUGE implications. There is a lot of APIs that are using do_memory_op. Fortunately most of them check for 'if (do_memory_op(..) < 0)' so will function properly. However there were some which printed the return value to the user. They have been fixed in: libxc: Don't assign return value to errno for E820 get/set xc_ calls. libxc: Check xc_sharing_* for proper return values. libxc: If xc_domain_add_to_physmap fails, include errno value libxc: Check xc_maximum_ram_page for negative return values. libxc: Check xc_domain_maximum_gpfn for negative return values Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Ian Campbell --- tools/libxc/xc_private.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxc/xc_private.c b/tools/libxc/xc_private.c index f4f2748c86..2eb44b6f00 100644 --- a/tools/libxc/xc_private.c +++ b/tools/libxc/xc_private.c @@ -516,7 +516,7 @@ int do_memory_op(xc_interface *xch, int cmd, void *arg, size_t len) { DECLARE_HYPERCALL; DECLARE_HYPERCALL_BOUNCE(arg, len, XC_HYPERCALL_BUFFER_BOUNCE_BOTH); - long ret = -EINVAL; + long ret = -1; if ( xc_hypercall_bounce_pre(xch, arg) ) { -- 2.30.2